Skip to content

Conversation

@ChristopherJHart
Copy link
Collaborator

Summary

  • Fixes bug where new issues created by tac-sync-issues command had incomplete file paths in the pull request files list
  • The generated_script_path was being used directly without prepending test_automation_scripts_directory
  • This caused file paths like iosxr/file.robot instead of workspace/jobfiles/iosxr/file.robot

Root Cause

When creating a new issue with a pull request, the code used generated_script_path directly:

files=[test_case_definition.generated_script_path]

But when updating an existing issue, the code correctly prepended the base directory:

script_path = test_automation_scripts_directory / test_case_definition.generated_script_path
files=[str(script_path)]

This inconsistency caused the process-issues command to look for files in the wrong location.

Test plan

  • Validated fix in CXTA-DISA-DISN-NextGen-Testbed Jenkins pipeline
  • File paths now correctly include the workspace/jobfiles/ prefix
  • Pull requests can be created successfully with the correct file attachments

🤖 AI Generation Metadata

  • AI Generated: Yes
  • AI Tool: claude-code
  • AI Model: opus-4.5
  • AI Contribution: ~100%
  • AI Reason: bug fix implementation
  • Human Oversight: Code reviewed and validated through Jenkins pipeline testing

…le path for new issues

When creating a new issue with a pull request, the generated_script_path was
being used directly without prepending the test_automation_scripts_directory.
This caused the file path to be incomplete (e.g., iosxr/file.robot instead of
workspace/jobfiles/iosxr/file.robot).

The existing issue update logic correctly prepended the directory, but the new
issue creation logic did not. This fix aligns both code paths to use the same
path construction approach.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ChristopherJHart ChristopherJHart merged commit 3acbbc1 into master Dec 18, 2025
2 checks passed
@ChristopherJHart ChristopherJHart deleted the fix/tac-sync-issues-file-path-construction branch December 18, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant