feat(ui): new Input #11110
Open
feat(ui): new Input #11110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new custom input component to replace antd and heroui inputs Update eslint config to enforce using the new input component
Add new Input component with support for Password and Button variants through compound pattern. Move input implementation to new directory structure and enhance with label and caption support. Remove old input implementation.
Move input component files to lowercase directory and simplify structure Remove unused button and password input components Update exports in components index file
build: update @radix-ui/react-slot dependency to v1.2.4
Remove complex Input component implementation and replace with simpler version Update components to use new Input and Textarea components from ui package
- Introduce new CompositeInput component with variants and password toggle - Add utility functions for null/undefined conversion - Export new components and types from index - Update input props interface and usage in input-group
- Refactor CompositeInput component with improved variants and styling - Add comprehensive Storybook stories for Input, InputGroup and CompositeInput components - Implement password toggle functionality and button variants - Include accessibility features and interactive examples
- Add disabled state variants for input components - Ensure password toggle button respects disabled state - Update disabled styling for better visual consistency - Add storybook examples for disabled password inputs
- Implement validation states for input components - Add real-time validation examples - Create form validation demos for different input types - Update styling for disabled and invalid states
Add prefix variants styling and prefix prop to CompositeInput component to support email inputs with fixed prefixes. Update stories to demonstrate various prefix use cases and interactive examples.
… hooks The startContent and endContent memoized values were removed and their logic was inlined directly in the JSX. This makes the code more straightforward and removes unnecessary memoization overhead since the calculations are simple.
Add new 'select' variant to CompositeInput component with support for select dropdown groups and items. Includes styling variants, type exports, and comprehensive storybook examples demonstrating various use cases like currency input, URL with protocol, phone with country code, and temperature with unit selectors.
…ss components" This reverts commit f7f689b.
Add null checks for email and select variants to prevent rendering issues when required props are missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
After this PR:
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Breaking changes
If this PR introduces breaking changes, please describe the changes and the impact on users.
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note