Make UPnP optional for security#339
Merged
kaenganxt merged 2 commits intoCitiesSkylinesMultiplayer:masterfrom Feb 20, 2026
Merged
Make UPnP optional for security#339kaenganxt merged 2 commits intoCitiesSkylinesMultiplayer:masterfrom
kaenganxt merged 2 commits intoCitiesSkylinesMultiplayer:masterfrom
Conversation
kaenganxt
requested changes
Feb 10, 2026
Member
kaenganxt
left a comment
kaenganxt
left a comment
There was a problem hiding this comment.
Thank you for your contribution! I agree that you should be able to disable UPnP.
But I don't agree that this is a security risk. Having UPnP enabled on your router for all devices in the network might be a security issue as malicious actors could open any port. But opening the CSM port automatically is rather low risk.
Most players are not aware of technical network details and probably don't even know what port forwarding means, so I would like to keep it enabled by default.
Could you please change the defaults to enabled?
Contributor
Author
|
I agree with you, I've set the default to enabled. |
kaenganxt
approved these changes
Feb 20, 2026
Member
kaenganxt
left a comment
kaenganxt
left a comment
There was a problem hiding this comment.
Looks good then, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not like the fact that UPnP is forced. I play on LAN and don't need to port-forward.