Skip to content

Resolve data manager deprecations. #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anoto-moniz merged 6 commits into from
Jan 5, 2026
Merged

Resolve data manager deprecations. #1007

anoto-moniz merged 6 commits into from
Jan 5, 2026

Conversation

@anoto-moniz
Copy link
Collaborator

@anoto-moniz anoto-moniz commented Dec 18, 2025

The first batch of deprecation resolutions.

  • Drop positional arguments and project_id from data objects.
  • Drop Ingestion.project_id.
  • FileCollection.ingest requires a project ID when build_table=True.
  • Ingestion.build_objects_async requires a project ID when build_table=True.
  • Adding ingredients via TableConfig.add_all_ingredients and TableConfig.add_all_ingredients_in_output requires a Team.
  • Drop ProjectCollection methods for data objects, as well as publishing/unpublishing datasets, owned_dataset_ids, and gemd_batch_delete.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@anoto-moniz
Resolve data manager deprecations.
f4f9be4 
* Drop positional arguments and project_id from data objects.
* Drop Ingestion.project_id.
* FileCollection.ingest requires a project ID when build_table=True.
* Ingestion.build_objects_async requires a project ID when build_table=True.
* Adding ingredients via TableConfig.add_all_ingredients and
TableConfig.add_all_ingredients_in_output requires a Team.
* Drop ProjectCollection methods for data objects, as well as
  publishing/unpublishing datasets, owned_dataset_ids, and gemd_batch_delete.
@anoto-moniz
Drop PEWs and PEW executions.
b86e242
@anoto-moniz
Drop training_data from predictor nodes.
0e8bffe
@anoto-moniz
Resolve other deprecations.
23efbaf
@anoto-moniz
Drop ResourceRef.
0f5a4ab
@anoto-moniz anoto-moniz marked this pull request as ready for review January 5, 2026 14:52
@anoto-moniz anoto-moniz requested a review from a team as a code owner January 5, 2026 14:52
kroenlein
kroenlein approved these changes Jan 5, 2026
View reviewed changes
Copy link
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anoto-moniz anoto-moniz merged commit f5ab7a0 into release/v4.0 Jan 5, 2026
41 checks passed
@anoto-moniz anoto-moniz deleted the resolve-data-manager-deprecations branch January 5, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kroenlein kroenlein kroenlein approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anoto-moniz @kroenlein