Skip to content

Conversation

@anoto-moniz
Copy link
Collaborator

@anoto-moniz anoto-moniz commented Dec 18, 2025

Citrine Python PR

  • Drop PEWs and PEW executions (in favor of predictor evaluations).
  • Drop training_data from predictor nodes, so it only exists on the top-level graph nodes.
  • Drop ResourceRef.
  • Drop IngredientRatioConstraint.basis_label_names and IngredientRatioConstraint.basis_ingredient_names.
  • Change EnumeratedDesignSpace.data to List[Mapping[str, str]].
  • Change ChemicalFormulaFeaturizer.powers to Optional[List[float]], and deprecate ChemicalFormulaFeaturizer.powers_as_float.

Description

Please briefly explain the goal of the changes/this PR.
The reviewer should be able to understand why the change is being made by reading this description
and its links (e.g. JIRA tickets).

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

return result


class ResourceRef(Serializable['ResourceRef']):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the PEW stuff, it turns out nothing uses ResourceRef any more.

*,
collection: Union[
Collection[PredictorEvaluationExecution],
Collection[PredictorEvaluation],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PredictorEvaluation should have been included previously. Same with the similar changes below.

Copy link
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anoto-moniz anoto-moniz marked this pull request as ready for review January 5, 2026 15:24
@anoto-moniz anoto-moniz requested a review from a team as a code owner January 5, 2026 15:24
@anoto-moniz anoto-moniz merged commit b611b55 into resolve-data-manager-deprecations Jan 5, 2026
@anoto-moniz anoto-moniz deleted the resolve-other-deprecations branch January 5, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants