Migrate build to pyproject.toml #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroenlein
commented
Oct 2, 2025
| *.cover | ||
| .hypothesis/ | ||
| .pytest_cache/ | ||
| prof/ |
Collaborator
Author
There was a problem hiding this comment.
Minor personal annoyance.
kroenlein
commented
Oct 2, 2025
Comment on lines
10
to
13
| try: | ||
| from typing import TypeAlias # Python 3.10+ | ||
| except ImportError: # pragma nocover | ||
| from typing_extensions import TypeAlias # Python 3.9 |
Collaborator
Author
There was a problem hiding this comment.
This is the only residual bit of dependency from the python-dependent subclassing. Removable with 3.10.
kroenlein
commented
Oct 2, 2025
| # D107: __init__ is self explanatory | ||
| # D301: backslash is used in making docstrings for sphinx to parse | ||
| # D401: Imperative mood requirement basically gets in the way | ||
| ignore = D100,D104,D105,D107,D301,D401 |
Collaborator
Author
There was a problem hiding this comment.
flake8 can't pull configuration from pyproject.toml, so it remains here.
kroenlein
commented
Oct 2, 2025
|
|
||
| [run] | ||
| omit = gemd/demo/* | ||
| omit = gemd/demo/* |
Collaborator
Author
There was a problem hiding this comment.
This can be removed in a follow up. It's required to pass tests common-gh-actions no longer references tox.ini.
anoto-moniz
reviewed
Oct 2, 2025
| build-backend = "setuptools.build_meta" | ||
|
|
||
| [tool.setuptools.dynamic] | ||
| version = {attr = "gemd.__version__.__version__"} |
Contributor
There was a problem hiding this comment.
Woah, this is a small but awesome little feature!
anoto-moniz
approved these changes
Oct 2, 2025
Contributor
anoto-moniz
left a comment
anoto-moniz
left a comment
There was a problem hiding this comment.
LGTM! I'll use this as a model for CP in the near future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEMD Python PR
Description
This PR migrates the gemd-python repository to take advantage of newer build capabilities and makes it compatible with the uv build tool & venv.
PR Type:
Adherence to team decisions