Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
🔥 New notebook just dropped! @amir-naveh , @TomerGoldfriend — come check out this shiny new addition to our repo. |
classiqdor
left a comment
classiqdor
left a comment
There was a problem hiding this comment.
Sharing some thoughts regarding the notebook
TomerGoldfriend
force-pushed
the
add_benchmarking_dir
branch
from
4865dc3 to
9894600
Compare
| """ | ||
| pass | ||
|
|
||
| def show(self) -> None: |
There was a problem hiding this comment.
I would have it as
| def show(self) -> None: | |
| def show(self, qprog: QuantumProgram | None) -> None: |
So that if we called synthesize somewhere else, we could pass it here, and wouldn't have to call it again
Likewise, we could have a property of .qprog which will call synthesize once, thus accessing self.qprog instead of self.main in most parts of the code
| if self.data_dir is None: | ||
| self.data_dir = str(p.parent) | ||
|
|
||
| async def reset_file(self) -> None: |
There was a problem hiding this comment.
An idea I just had: maybe we can have reset_file do "copy this file to this_file.old" and then create an empty file?
This way we'd have a little bit of a backup for the results
| async with FILE_LOCK: | ||
| dump_results(self.filename, []) | ||
|
|
||
| def _append_error_log( |
There was a problem hiding this comment.
I think this should also be async def and async with lock.
not sure, but I think it won't hurt
| @@ -0,0 +1,349 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,349 @@ | |||
| { | |||
There was a problem hiding this comment.
maybe this can be aligned like a table. It's not important, but can be nice if this status is used a lot
Reply via ReviewNB
| @@ -0,0 +1,409 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #34. async def submit(self, qprog: QuantumProgram) -> str:
this function is duplicate
Reply via ReviewNB
| @@ -0,0 +1,360 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #10. from hardware import HardwareRunner
maybe we can put all the imports under a utils folder, and have a single line of from utils import BenchmarkExample, ResultCollector, HardwareRunner, HARDWARES
Reply via ReviewNB
| @@ -0,0 +1,360 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #1. # How to construct main for a given number of qubits
the comment may not be needed
Reply via ReviewNB
…nchmark, include num_shots in title, and allow descriptions
TomerGoldfriend
force-pushed
the
add_benchmarking_dir
branch
from
653174b to
1810baa
Compare
|
🚀 Incredible, @TomerGoldfriend! You've merged your 67th PR! 🎯🎊 Your ongoing commitment to classiq-library is truly remarkable. You're a driving force in our community! 🚀 We are grateful for your dedication! 💫 |
4 participants
PR Description
This PR adds a benchmarking directory, with an adder example.
This is still WIP