Skip to content

Conversation

@nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Sep 17, 2025

Purpose

Use ClimaCore's CommonGrids and CommonSpaces to create spaces.

To-do

Content

  • Added new grids.jl file with grid constructors: SphereGrid, ColGrid, BoxGrid, PlaneGrid. Topography is handled by a function hypsography_function_from_topography which returns a hypsography function passed to ClimaCore.
  • New get_spaces(grid, context) function replaces parsed-args dependent get_spaces(parsed_args, params, comms_ctx)
  • Removed old space creation functions: periodic_line_mesh, periodic_rectangle_mesh, make_hybrid_spaces
  • Replaced CTh (horizontal contravariant) with CT12
  • Updated ∂ᶜK_∂ᶜuₕ field type from DiagonalMatrixRow{Adjoint{FT, CTh{FT}}} to use CT12
  • Updated g³ʰ() to return explicit CT12 components using SMatrix
  • Updated is_column and do_dss to match new spaces
  • Updated ci_plots.jl and PrecompileCI
  • Updated gravity wave tests and other test helpers

  • I have read and checked the items on the review checklist.

@nefrathenrici nefrathenrici force-pushed the ne/grids branch 2 times, most recently from a878a51 to 1342d7b Compare November 5, 2025 18:18
@nefrathenrici nefrathenrici force-pushed the ne/grids branch 3 times, most recently from c1b1a4d to 725681b Compare November 21, 2025 18:27
@nefrathenrici nefrathenrici force-pushed the ne/grids branch 4 times, most recently from 7327a63 to 3fbfbfe Compare December 2, 2025 18:25
@nefrathenrici nefrathenrici marked this pull request as ready for review December 2, 2025 20:59
@nefrathenrici nefrathenrici force-pushed the ne/grids branch 9 times, most recently from 3f51371 to 3d809fd Compare December 4, 2025 22:55
Copy link
Member

@dennisYatunin dennisYatunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Excited to have columns that are actually real columns after this PR

@nefrathenrici nefrathenrici force-pushed the ne/grids branch 3 times, most recently from be2682e to 6d662df Compare December 5, 2025 19:30
@nefrathenrici nefrathenrici force-pushed the ne/grids branch 2 times, most recently from 28655e6 to db2e99d Compare December 5, 2025 22:32
@nefrathenrici nefrathenrici force-pushed the ne/grids branch 10 times, most recently from 41d71e3 to 66e8f61 Compare December 8, 2025 04:07
@nefrathenrici nefrathenrici added this pull request to the merge queue Dec 8, 2025
Merged via the queue into main with commit 409c47c Dec 8, 2025
14 of 17 checks passed
@nefrathenrici nefrathenrici deleted the ne/grids branch December 8, 2025 09:22
@nefrathenrici nefrathenrici mentioned this pull request Dec 12, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants