-
Notifications
You must be signed in to change notification settings - Fork 27
Use CommonSpaces/Grids #4021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Use CommonSpaces/Grids #4021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6e453a to
c8ece52
Compare
09527fa to
0d59561
Compare
0d59561 to
5a36b1e
Compare
a878a51 to
1342d7b
Compare
c1b1a4d to
725681b
Compare
7327a63 to
3fbfbfe
Compare
3f51371 to
3d809fd
Compare
dennisYatunin
approved these changes
Dec 5, 2025
Member
dennisYatunin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Excited to have columns that are actually real columns after this PR
be2682e to
6d662df
Compare
nefrathenrici
commented
Dec 5, 2025
28655e6 to
db2e99d
Compare
41d71e3 to
66e8f61
Compare
66e8f61 to
672d0c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use ClimaCore's CommonGrids and CommonSpaces to create spaces.
To-do
Content
hypsography_function_from_topographywhich returns a hypsography function passed to ClimaCore.get_spaces(grid, context)function replaces parsed-args dependentget_spaces(parsed_args, params, comms_ctx)periodic_line_mesh,periodic_rectangle_mesh,make_hybrid_spaces∂ᶜK_∂ᶜuₕfield type fromDiagonalMatrixRow{Adjoint{FT, CTh{FT}}}to use CT12is_columnanddo_dssto match new spaces