Add RCEMIPII analytic sounding initial condition #4127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trontrytel
reviewed
Dec 2, 2025
trontrytel
reviewed
Dec 2, 2025
trontrytel
reviewed
Dec 2, 2025
trontrytel
reviewed
Dec 2, 2025
trontrytel
reviewed
Dec 2, 2025
trontrytel
reviewed
Dec 2, 2025
trontrytel
approved these changes
Dec 2, 2025
Member
trontrytel
left a comment
trontrytel
left a comment
There was a problem hiding this comment.
LGTM! Left some minor comments about how I would vote to handle the initial condition option.
From the plots I can't tell how accurately we match the paper because the axis etc are slightly different.
Also, do you have a CI case with it already? And if not, would it be useful to add one?
haakon-e
approved these changes
Dec 2, 2025
Member
haakon-e
left a comment
haakon-e
left a comment
There was a problem hiding this comment.
Great work on the PR! Apart from the pressure units, I think everything looks consistent with the paper.
The code suggestions are for improved readability and documentation.
oalcabes
force-pushed
the
oa/rce_initial_sounding
branch
5 times, most recently
from
8ade5b6 to
1273629
Compare
szy21
reviewed
Dec 2, 2025
Member
|
And I think Wing et. al. (2018) RCEMIP is actually RCEMIPI, not RCEMIPII:) |
oalcabes
force-pushed
the
oa/rce_initial_sounding
branch
7 times, most recently
from
a401988 to
ac0dce4
Compare
trontrytel
reviewed
Dec 4, 2025
trontrytel
approved these changes
Dec 4, 2025
haakon-e
reviewed
Dec 4, 2025
oalcabes
force-pushed
the
oa/rce_initial_sounding
branch
2 times, most recently
from
24d04ae to
622bd24
Compare
oalcabes
force-pushed
the
oa/rce_initial_sounding
branch
8 times, most recently
from
6ec9175 to
2123564
Compare
szy21
force-pushed
the
oa/rce_initial_sounding
branch
from
2123564 to
8dbec5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I am adding the initial sounding from the Wing et. al. (2018) RCEMIP paper. This sounding should be used for RCEMIP simulations. There are three options for initial temps of 295K, 300K, and 305K. This PR also adds an option for a cloud resolving model (CRM) setup of RCEMIP with 1M and noneq to ci.
See here the analytic profile derived from an observation from Wing et. al. (2018) (left) and the Julia implementation (right).
