use the correct a_m in mixing length #4135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapios
approved these changes
Dec 4, 2025
Member
tapios
left a comment
tapios
left a comment
There was a problem hiding this comment.
Looks good. But isn't there a way to use phi directly from SurfaceFluxes, with the surface flux parameterization being part of a config choice and passing the same config choice through here?
Member
Author
I'm not sure, but I'll take a look. |
costachris
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The Businger a_m was used in the stable branch of mixing length. This PR corrects it to use Gryanik a_m. Also modifies the stability function to use the same optimization as the one in SurfaceFluxes.
To-do
Content