merge sgs_diffusive_flux functions #4154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
reviewed
Dec 10, 2025
Comment on lines
492
to
495
| ᶠstrain_rate = | ||
| turbconv_model isa PrognosticEDMFX ? | ||
| compute_strain_rate_face_vertical(ᶜu⁰) : | ||
| compute_strain_rate_face_vertical(ᶜu) |
Member
There was a problem hiding this comment.
Suggested change
| ᶠstrain_rate = | |
| turbconv_model isa PrognosticEDMFX ? | |
| compute_strain_rate_face_vertical(ᶜu⁰) : | |
| compute_strain_rate_face_vertical(ᶜu) | |
| ᶠstrain_rate = compute_strain_rate_face_vertical(ᶜu) |
szy21
approved these changes
Dec 10, 2025
Member
szy21
left a comment
szy21
left a comment
There was a problem hiding this comment.
Thanks! Let's keep removing more code!
sajjadazimi
force-pushed
the
sa/change_gs_tracers_diff_back
branch
from
b1a8a7a to
52d9e65
Compare
sajjadazimi
force-pushed
the
sa/change_gs_tracers_diff_back
branch
from
52d9e65 to
2c0371e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
This won't pass until #4155 is merged I think. After that you can rebase it and it should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
merge sgs_diffusive_flux functions for pedmf and dedmf