Skip to content

move restore into Checkpointer #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
juliasloan25 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

move restore into Checkpointer #1612

juliasloan25 wants to merge 1 commit into from

Conversation

@juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Dec 11, 2025 •
edited
Loading

Purpose

restore! is a function used to restart caches. This PR moves it out of experiments/ and into the Checkpointer module. This is the first step of a larger effort to move code out of experiments and into src.

See #1610 for a list of other files/functions to move in other PRs.

Content

  • move restore! into the Checkpointer module
  • remove experiments/ClimaEarth/shared/ folder and contents
  • update function calls to qualify with Checkpointer.
  • update docstrings to be more descriptive
  • add to Checkpointer API docs
  • add tests
  • verify buildkite results are unchanged
  • I have read and checked the items on the review checklist.

@juliasloan25 juliasloan25 marked this pull request as ready for review December 11, 2025 00:50
@juliasloan25 juliasloan25 mentioned this pull request Dec 11, 2025
Open
@juliasloan25 juliasloan25 force-pushed the js/restore branch 2 times, most recently from a580e31 to 117ad23 Compare December 11, 2025 17:56
ph-kev
ph-kev approved these changes Dec 12, 2025
View reviewed changes
test/checkpointer_tests.jl
Comment on lines +37 to +38
dir = "test_checkpoint"
mkpath(dir)
Copy link
Member

@ph-kev ph-kev Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to make a temporary directory with mktempdir, so that it is automatically removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ph-kev ph-kev ph-kev approved these changes

@imreddyTeja imreddyTeja Awaiting requested review from imreddyTeja

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juliasloan25 @ph-kev