-
Notifications
You must be signed in to change notification settings - Fork 6
Updated reference temperature to reflect dycore manuscript #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage 90.76% 90.76%
=======================================
Files 1 1
Lines 130 130
=======================================
Hits 118 118
Misses 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@nefrathenrici ClimaAtmos Project.toml currently tracks |
tapios
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would you like to add the exponent parameter (e.g., 'temperature_reference_decay_exponent' (=7) in this same PR, so we have it all?
19c396c to
8e915d8
Compare
nefrathenrici
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Could you update the NEWS.md as well?
8e915d8 to
a1b5c50
Compare
a1b5c50 to
f739f9e
Compare
Oh, thanks for reminding me! Done. :) |
Purpose and content
In the manuscript, we changed
temperature_surface_referenceto288 Kandtemperature_min_referenceto215 K, respectively. This PR synchronises the default parameters with those in the manuscript.To-do
Content