Some Unit tests #11
Merged
Some Unit tests #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielbmoro
changed the title
Unit tests for search books
pnalvarez
reviewed
Sep 25, 2025
| @@ -0,0 +1,10 @@ | |||
| import 'package:mibook/layers/domain/models/book_list_domain.dart'; | |||
|
|
|||
| final fakeBookDomain = BookDomain( | |||
Collaborator
There was a problem hiding this comment.
For one moment I was wondering what the hell is a FacebookDomain....
pnalvarez
reviewed
Sep 25, 2025
| import 'get_book_details_test.mocks.dart'; | ||
|
|
||
| void main() { | ||
| late MockISearchRepository mockSearchRepository; |
Collaborator
There was a problem hiding this comment.
Could we avoid late variables in the tests? That could provoke crashes in our CI.
Contributor
Author
There was a problem hiding this comment.
I don’t understand why this would cause any issues in our CI/CD pipeline, since we’re initializing them properly in the setUp method.
Anyways, I will merge the PR. If you think it is important to address this in the future, let's create an issue in our repo.
🤗
pnalvarez
reviewed
Sep 25, 2025
| import 'search_books_test.mocks.dart'; | ||
|
|
||
| void main() { | ||
| late MockISearchRepository mockSearchRepository; |
pnalvarez
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
di.config.dartto gitignore file;