Github link validation - prep for user input#269
Closed
courte wants to merge 15 commits intoCodeMontageHQ:masterfrom
Closed
Github link validation - prep for user input#269courte wants to merge 15 commits intoCodeMontageHQ:masterfrom
courte wants to merge 15 commits intoCodeMontageHQ:masterfrom
Conversation
Member
|
Using the url get_github_details('https://github.com/CodeMontageHQ/codemontage/pull/269')
=> {:github_org=>"CodeMontageHQ/codemontage/pull", :github_repo=>"269"} |
Member
|
Nice example, @acrogenesis! Thank you. |
Member
Author
|
Thanks for the heads up, @acrogenesis! I've added some commits that (a) add your example to our existing specs & (b) account for word chars & dashes instead of any non-whitespace character (which was clearly far too broad). The regex is ugly but (currently, maybe, fingers-crossed) gets the job done. |
Member
Author
|
Simpler, cuter solution at #286. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code prepares to allow users to input a github link when adding new projects to the platform.