NW6|Fidaa Bashir|HTML-CSS|Module-Project|week 1#645
NW6|Fidaa Bashir|HTML-CSS|Module-Project|week 1#645Fidaabashir89 wants to merge 1 commit intoCodeYourFuture:masterfrom
Conversation
✅ Deploy Preview for cyf-module-project-html-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Ara225
left a comment
Ara225
left a comment
There was a problem hiding this comment.
Hiya,
Good work, nearly there :) Copying is 100% harder work than writing from scratch but a good practice. Do you want to discuss grid and hight/width in more detail?
| list-style: none; | ||
| font-size: normal; | ||
| color: lightgrey; | ||
| padding-left: 8rem; |
There was a problem hiding this comment.
The header is more to the left than it should be, should be right aligned as shown in the picture of the sample site
| .meet{ | ||
| font-weight: bold; | ||
| } | ||
| .Store{ |
There was a problem hiding this comment.
This is a small niggle, but it's worth thinking about. You're using a captial letter in this classname, and you've done it nowhere else. This can be annoying as CSS is case senstive so easy to make a mistake. It's up to you though what you want to do
| background-color: rgb(235, 114, 66); | ||
| border-radius: 10px; | ||
| padding: 10px 20px; | ||
| margin-bottom: 5rem; |
There was a problem hiding this comment.
This Button is a bit off I'm afraid. Has a white border and the border-radius is too big so it's more rounded than it outght to be
| font-weight: bold; | ||
| } | ||
| .copyrights{ | ||
| color: grey; |
There was a problem hiding this comment.
THe test on this is very small and almost unreadable for me so would make a bit bigger
| justify-content: center; | ||
| border: solid 1px rgb(224, 229, 229); | ||
| border-radius: 15px; | ||
| margin-left: 30px; |
There was a problem hiding this comment.
In the picture, the icons had a bit more space around them - they weren't touching the border
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> | ||
| <!-- All the images you need are in the 'img' folder --> | ||
|
|
||
| <header class="header"><img class="karma-logo" src="./img/karma-logo.svg" alt="karma-logo"> |
There was a problem hiding this comment.
No massive complants on the HTML here: good use of sematic HTML, tags have alt attrs, would say that the naming convensions could be better: nav-liwould maybe make more sense as nav-item but this is about developing your style :)
2 participants
Your Details
Homework Details
Notes
What did you find easy? writing the html
What did you find hard? to get the right size for images, and also found that to code a copy page is more difficult than to code new one ☝️
What do you still not understand? I'm still need to understand grid, width and height measurements.
Any other notes?