Birmingham-WM5-HTML/CSS-Rawan-Almutairi-Karma Store| Week1/2#656
Open
rawan0-0 wants to merge 1 commit intoCodeYourFuture:masterfrom
Open
Birmingham-WM5-HTML/CSS-Rawan-Almutairi-Karma Store| Week1/2#656rawan0-0 wants to merge 1 commit intoCodeYourFuture:masterfrom
rawan0-0 wants to merge 1 commit intoCodeYourFuture:masterfrom
Conversation
…structions-clarifications Adds tasks and designs, and splits these into folders <!-- The title for your pull request should be made in this format Birmingham- WM5-Rawan-Almutairi-HTML/CSS-1/2 CITY CLASS_NO - FIRST_NAME LAST_NAME - MODULE - WEEK_NO For example, London Class 7 - Chris Owen - HTML/CSS - Week 1 Please complete the details below this message --> **Volunteers: Are you marking this coursework?** _You can find a guide on how to mark this coursework in `HOW_TO_MARK.md` in the root of this repository_ # Your Details - Your Name: - Your City: - Your Slack Name: # Homework Details - Module: - Week: # Notes - What did you find easy? - What did you find hard? - What do you still not understand? - Any other notes?
✅ Deploy Preview for cyf-module-project-html-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rawan0-0
changed the title
rawan0-0
changed the title
hoduola5
requested changes
Nov 20, 2023
hoduola5
left a comment
hoduola5
left a comment
There was a problem hiding this comment.
Well done @rawan0-0,
I have got some feedback for you.
Try and fill PR template to reflect your name and other questions there to help guide you properly.
Your Home page image is not showing I suggest you check the src to see if you fill in the right image source.
| <link href='https://fonts.googleapis.com/css?family=Roboto:400,500,300' rel='stylesheet' type='text/css'> | ||
| <link rel="stylesheet" href="css/normalize.css"> | ||
| <link rel="stylesheet" href="css/style.css"> | ||
| <link rel="stylesheet" href="css\style.css"> |
There was a problem hiding this comment.
In this line of code your CSS is not well-linked you need to change " \ " to "/" to look like this (href="css/style.css").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tasks and designs, and splits these into folders
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?