Sheffield | 25-SDC-Nov | Sheida Shabankari | Sprint 1 | Can't log in from profile page#104
Open
sheida-shab wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
Conversation
sheida-shab
added
Needs Review
illicitonion
reviewed
Feb 4, 2026
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This generally looks good, and your description is really clear.
There appears to be an unrelated change in this PR related to hashtag infinite requests - please can you remove that from this PR?
illicitonion
added
Reviewed
sheida-shab
force-pushed
the
Feat-fixBug-loginFromProfilePage
branch
from
ba52454 to
ebc0759
Compare
Author
|
Hi, |
sheida-shab
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary:
Previously, visiting another user's profile after logging out and logging back in caused a server error (501: Server does not support this operation). The root cause was that the login button was handled via a click event, which did not properly trigger form submission and associated server logic in some cases.
The first login succeeded because the DOM and state were in a clean initial state. After logout, the login view was re-rendered, and the click-based handler was no longer reliably attached.
This PR changes the login flow to handle the form submit event instead of just the button click, ensuring that logging in fully executes the server-side login process. Handling login via the form’s submit event ensures consistent behaviour across re-renders. After this fix, users can log out and log back in, and visiting another user's profile works as expected.