Skip to content

WEST MIDLANDS | ITP JAN 26 | ZIAD AHMED | Sprint 1 | Wireframe#1031

Open
ZiadMakkawi wants to merge 2 commits intoCodeYourFuture:mainfrom
ZiadMakkawi:Ziad/Wireframe
Open

WEST MIDLANDS | ITP JAN 26 | ZIAD AHMED | Sprint 1 | Wireframe#1031
ZiadMakkawi wants to merge 2 commits intoCodeYourFuture:mainfrom
ZiadMakkawi:Ziad/Wireframe

Conversation

@ZiadMakkawi
Copy link

@ZiadMakkawi ZiadMakkawi commented Jan 23, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Added required content using semantic HTML elements
  • Updated layout and spacing in CSS to match the provided wireframe

@netlify
Copy link

netlify bot commented Jan 23, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit ce9c573
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6973d2fb43a3b600090aa8c2
😎 Deploy Preview https://deploy-preview-1031--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@ZiadMakkawi ZiadMakkawi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026
@ZiadMakkawi ZiadMakkawi changed the title WEST MIDLANDS | JAN 26 ITP | SPRINT 1 ONBOARDING |Wireframe WEST MIDLANDS | JAN 26 ITP |ZIAD AHMED| SPRINT 1 ONBOARDING |Wireframe Jan 23, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026
@github-actions

This comment has been minimized.

@ZiadMakkawi ZiadMakkawi changed the title WEST MIDLANDS | JAN 26 ITP |ZIAD AHMED| SPRINT 1 ONBOARDING |Wireframe WEST MIDLANDS | ITP JAN 26 | ZIAD AHMED | SPRINT 1 ONBOARDING | Wireframe Jan 23, 2026
@github-actions

This comment has been minimized.

@ZiadMakkawi ZiadMakkawi changed the title WEST MIDLANDS | ITP JAN 26 | ZIAD AHMED | SPRINT 1 ONBOARDING | Wireframe WEST MIDLANDS | ITP JAN 26 | ZIAD AHMED | SPRINT 1 | Wireframe Jan 23, 2026
@github-actions

This comment has been minimized.

@ZiadMakkawi ZiadMakkawi changed the title WEST MIDLANDS | ITP JAN 26 | ZIAD AHMED | SPRINT 1 | Wireframe WEST MIDLANDS | ITP JAN 26 | ZIAD AHMED | Sprint 1 | Wireframe Jan 23, 2026
@ZiadMakkawi ZiadMakkawi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module Module-Onboarding The name of the module. labels Jan 31, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A well-prepared PR makes it easier for reviewers to approve it with minimal back-and-forth.
Can you take a look at this PR Guide and General Feedback to see if there
is anything you can do to make your PR more robust and ready?
Doing so can help speed up the review process.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026
@ZiadMakkawi
Copy link
Author

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Added required content using semantic HTML elements
  • Updated layout and spacing in CSS to match the provided wireframe

@cjyuan
Copy link
Contributor

cjyuan commented Feb 3, 2026

The format looks good. Can you update the PR description with what you left in the comment?

@ZiadMakkawi ZiadMakkawi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 6, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 6, 2026

Code is free of syntax errors and well indented. All requirements met. Well done!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 6, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 6, 2026

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback. (You can practice this in future PRs)
    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
      • You may find the suggestions in this PR Guide useful.
    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants