Skip to content

LONDON | JANUARY-26 | GLORIA MANKRADO | Sprint 1 | WIREFRAME#1039

Open
gloriamanks wants to merge 9 commits intoCodeYourFuture:mainfrom
gloriamanks:feature/wireframe
Open

LONDON | JANUARY-26 | GLORIA MANKRADO | Sprint 1 | WIREFRAME#1039
gloriamanks wants to merge 9 commits intoCodeYourFuture:mainfrom
gloriamanks:feature/wireframe

Conversation

@gloriamanks
Copy link

@gloriamanks gloriamanks commented Jan 24, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Inserted three articles explaining What the purpose of readme file, wireframe and branches.

upon getting reviewed:

  • Moved article images from CSS background-image to elements inside each
  • Removed article-specific background image CSS
  • Updated article images to span the full width of their articles and align consistently in the grid.
  • Adjusted the container width to 1024px so the layout displays correctly at normal browser zoom.
  • Verified that the layout matches the provided wireframe and that all articles, images, and links align as expected.

Questions

I have none at the moment.

@netlify
Copy link

netlify bot commented Jan 24, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 10ae6f9
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/698677beb3227b00089fc491
😎 Deploy Preview https://deploy-preview-1039--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@gloriamanks gloriamanks added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@gloriamanks gloriamanks added Complete Volunteer to add when work is complete and all review comments have been addressed. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Complete Volunteer to add when work is complete and all review comments have been addressed. labels Jan 28, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A well-prepared PR makes it easier for reviewers to approve it with minimal back-and-forth.
Can you take a look at this PR Guide and General Feedback to see if there
is anything you can do to make your PR more robust and ready?

Doing so can help speed up the review process.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 3, 2026
@gloriamanks gloriamanks added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 4, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is free of syntax error and well indented. Well done.

  • Can you center the text content in the footer (to match the wireframe image)?

  • Currently the footer content and the article content can overlap. Can you prevent this from happening?

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 5, 2026
@gloriamanks gloriamanks added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 6, 2026
@gloriamanks
Copy link
Author

hi @cjyuan,
centered the fixed footer to match the wireframe image

@cjyuan
Copy link
Contributor

cjyuan commented Feb 6, 2026

Can you prevent this (see pic) from happening? When the text overlap, it makes reading difficult.

image

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 6, 2026
@gloriamanks
Copy link
Author

Hi @cjyuan

I have added a background to the footer to resolve the issue of readability when scrolling.

@gloriamanks gloriamanks added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 6, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 6, 2026

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 6, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 6, 2026

The cohort name should be 26-ITP-Jan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants