WestMidlands | 26-ITP-Jan | Adedolapo Bamiduro | Sprint 2 | Form Controls #1127

codebydolz · 2026-02-03T17:53:24Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

added the needed answers to form controls

netlify · 2026-02-03T17:53:32Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`d069432`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6987719d49dbe100085b02d3
😎 Deploy Preview	https://deploy-preview-1127--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 91 (🟢 up 5 from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

cjyuan

According to https://validator.w3.org/, there are some warnings in your code. Can you address them?
Currently a user can submit the form without filling in all input.
Common practice is to keep the label of a radio button on the right (instead of at the bottom)

Note: Embedded CSS is still CSS. Supposedly the requirement says "No CSS", but you can keep them.

Form-Controls/index.html

cjyuan · 2026-02-06T23:39:52Z

Form-Controls/index.html

+          <select name="size" id="size">
+            <option value="XS">Extra Small</option>
+            <option value="S">Small</option>
+            <option value="M">Medium</option>
+            <option value="L">Large</option>
+            <option value="XL">Extra Large</option>
+            <option value="XXL">Extra Extra Large</option>
+          </select>


There is a way to configure a <select> element so that no option is selected by default, allowing the user to make an explicit choice.

done @cjyuan

cjyuan · 2026-02-06T23:41:16Z

Form-Controls/index.html

+            <input type="radio" name="color" id="color-blue" value="Blue">
+            <label for="color-blue">Blue</label>


We won't need to use id and for if we encode this as:

<label> <input type="radio" name="color" value="Blue"> Blue </label>

cjyuan · 2026-02-06T23:45:27Z

Form-Controls/index.html

+        <div class="form-row">
+          <label for="password">Password</label>
+          <input type="password" name="password" id="password" required aria-required="true">
+        </div>


I am glad that you are trying different things, but I think it is weird to include a password input field in a T-shirt ordering form. :)

… button

cjyuan

1

Can you improve the Lighthouse Accessibility score to 100?

You may find a way to overcome this issue in #cyf-questions-support channel on Slack.

2

According to https://validator.w3.org/, there are errors in your code. Can you fix them?

codebydolz · 2026-02-07T17:11:39Z

i think i have successfully updated the lighthouse @cjyuan

cjyuan · 2026-02-07T23:39:36Z

Changes look good. Well done.

According to https://validator.w3.org/, there are some warnings in your code. Can you address them? I will mark this PR "Complete" first.

codebydolz · 2026-02-08T19:37:15Z

Hello, i have been trying to find the error in the code, but i cant seem to find it.

cjyuan · 2026-02-08T19:41:16Z

I mentioned "warnings", not "errors".

Addded formcontrols to answer task questions

d4efe1e

This comment has been minimized.

Sign in to view

codebydolz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026

This comment has been minimized.

Sign in to view

Poonam-raj added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026

codebydolz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026

cjyuan reviewed Feb 6, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 6, 2026

adedolapo added 2 commits February 7, 2026 14:47

Refactor form layout and improve accessibility features

2ab555c

Add default option to size select and fix indentation for color radio…

714a258

… button

codebydolz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 7, 2026

cjyuan reviewed Feb 7, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 7, 2026

Refactor form structure and improve accessibility for input fields

d069432

codebydolz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 7, 2026

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 7, 2026

cjyuan mentioned this pull request Feb 8, 2026

Birmingham | 26-ITP-Jan- | Adedolapo Bamiduro | Sprint 2 | Form Controls #1125

Closed

4 tasks

		<input type="radio" name="color" id="color-blue" value="Blue">
		<label for="color-blue">Blue</label>

Uh oh!

WestMidlands | 26-ITP-Jan | Adedolapo Bamiduro | Sprint 2 | Form Controls #1127

Are you sure you want to change the base?

WestMidlands | 26-ITP-Jan | Adedolapo Bamiduro | Sprint 2 | Form Controls #1127

Uh oh!

Conversation

codebydolz commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

netlify bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

codebydolz Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

1

2

Uh oh!

codebydolz commented Feb 7, 2026

Uh oh!

cjyuan commented Feb 7, 2026

Uh oh!

codebydolz commented Feb 8, 2026

Uh oh!

cjyuan commented Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codebydolz commented Feb 3, 2026 •

edited

Loading

netlify bot commented Feb 3, 2026 •

edited

Loading