Birmingham | 26-ITP-Jan | Ayodeji Ayorinde | Sprint 2 | Form Controls#1141
Open
Ayogit1 wants to merge 6 commits intoCodeYourFuture:mainfrom
Open
Birmingham | 26-ITP-Jan | Ayodeji Ayorinde | Sprint 2 | Form Controls#1141Ayogit1 wants to merge 6 commits intoCodeYourFuture:mainfrom
Ayogit1 wants to merge 6 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Ayogit1
added
the
Needs Review
Author
|
@cjyuan, I closed the previous PRs as I could not change the title. |
3 tasks
Contributor
|
Can you address the inline comments I left on your previous PR? #1044 |
cjyuan
reviewed
Feb 5, 2026
cjyuan
added
Reviewed
Removed multiple 'Required' since it is not necessary to use required on every radio button in the same group.
Ayogit1
added
Needs Review
Contributor
|
I left these comments on your closed PR. Can you address them? |
cjyuan
removed
the
Needs Review
Ayogit1
added
the
Needs Review
cjyuan
reviewed
Feb 7, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you add an input element that would allow a user to submit the form data?
| <body> | ||
|
|
||
| <main> | ||
| <form action="/my-handling-form-page" method="post"> |
Contributor
There was a problem hiding this comment.
- Why use POST method to submit the form data?
Comment on lines
+36
to
+48
| <input type="radio" required name="colour" value="Green"> | ||
| Green | ||
| </label> | ||
|
|
||
| <label> | ||
| <input type="radio" required name="colour" value="Red"> | ||
| Red | ||
| </label> | ||
|
|
||
| <label> | ||
| <input type="radio" required name="colour" value="Blue"> | ||
| Blue | ||
| </label> |
Contributor
There was a problem hiding this comment.
Among the radio buttons in the same button group (same name attribute value), we can just assign required to one of them.
cjyuan
removed
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR contains the completed work on the Form Controls
Questions