Skip to content

Glasgow | 26-SDC-Mar | Mohammed Abdoon | Sprint 2 | Shell Pipelines#411

Open
M-Abdoon wants to merge 9 commits into
CodeYourFuture:mainfrom
M-Abdoon:shell-pipelines
Open

Glasgow | 26-SDC-Mar | Mohammed Abdoon | Sprint 2 | Shell Pipelines#411
M-Abdoon wants to merge 9 commits into
CodeYourFuture:mainfrom
M-Abdoon:shell-pipelines

Conversation

@M-Abdoon
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • [ X] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ X] My changes meet the requirements of the task
  • [ X] I have tested my changes
  • [ X] My changes follow the style guide

Changelist

exercises solved.

@M-Abdoon M-Abdoon added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 21, 2026
Copy link
Copy Markdown

@SlideGauge SlideGauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Could you add trailing new lines please to all the scripts?
  2. You accidentally committed "implement-shell-tools" as well, remove them please

# The input for this script is the events.txt file.
# TODO: Write a command to show how many times anyone has entered and exited.
# It should be clear from your script's output that there have been 5 Entry events and 4 Exit events.
sort events.txt | uniq -c No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This groups by the full line (person + event type), producing 2 Entry German, 1 Entry Mariana, etc. - a reader has to sum the numbers to find the totals. The task requires the output to clearly show 5 Entry and 4 Exit. You need to count by event type only

# TODO: Write a command to show how many times anyone has entered and exited.
# It should be clear from your script's output that there have been 5 Entry events and 4 Exit events.
# The word "Event" should not appear in your script's output.
cut -d' ' -f2 events-with-timestamps.txt | sort | uniq -c No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

events-with-timestamps.txt is tab-delimited, not space-delimited, thus it affects the work of this script

Comment thread shell-pipelines/ls-grep/script-03.sh Outdated

# TODO: Write a command to output the names of the files in the sample-files directory whose name starts with an upper case letter and doesn't contain any other upper case letters.
# Your output should contain 7 files.
ls sample-files | grep '^[A-Z][a-z]*$'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it pass something like File1.txt?

Comment thread shell-pipelines/ls-grep/script-04.sh Outdated

# TODO: Write a command to count the number of files in the sample-files directory whose name starts with an upper case letter and doesn't contain any other upper case letters.
# Your output should be the number 7.
ls sample-files | grep '^[A-Z][a-z]*$' | wc -l No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it pass something like File2.txt?

@SlideGauge
Copy link
Copy Markdown

Could you check my notes please?

@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 3, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@M-Abdoon
Copy link
Copy Markdown
Author

Could you check my notes please?

I checked your notes and fixed the errors. Thank you for your feedback.

@M-Abdoon M-Abdoon added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants