Add next-class-day-plan shortcode and wire to ITP index (fixes #1119)#1556
Add next-class-day-plan shortcode and wire to ITP index (fixes #1119)#1556JohnnyRobs19 wants to merge 16 commits intoCodeYourFuture:mainfrom
Conversation
👷 Deploy request for cyf-curriculum pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-piscine pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-sdc pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-tracks pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-launch pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-itd pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-common pending review.Visit the deploys page to approve it
|
|
Thanks for putting this together! It generally looks reasonable, but one thing I'm not sure about is the As far as I can tell, this pull request doesn't create a menu called scheduled - what's meant to be in it? It looks like it's meant to be each sprint? We already have a menu called "syllabus" which contains each module, and then a menu_level called "module" which contains each sprint within a module - could we use these existing menus, rather than having to introduce another one? |
|
Hi @illicitonion, Thank you for the feedback. I have reworked the PR so the shortcode now pulls sprint day‑plan pages directly from the existing syllabus → module menu structure—no additional scheduled menu is needed. The logic lives in common-theme/layouts/shortcodes/next-class-day-plan.html, which uses .Page.CurrentSection to gather the module’s pages and select the correct sprint link. I also removed the redundant partial/shortcode from org-cyf-theme and updated the README to note that next-class-day-plan relies on the current menu hierarchy. Let me know if anything still looks off, and I will be happy to tweak further. |
What does this change?
Common Content?
Common Theme?
Issue number: #1119
Org Content?
Checklist
Who needs to know about this?
Please review: @SallyMcGrath
Before / After (artifacts)
Before
org-cyf-itp/content/_index.md(pre-change)After
common-theme/layouts/shortcodes/next-class-day-plan.htmlorg-cyf-itp/content/_index.mdNotes
org-cyf-itp/content/_index.mdusing{{< next-class-day-plan >}}.failed to render shortcode "next-class-day-plan", ensure the shortcode file path is exactlycommon-theme/layouts/shortcodes/next-class-day-plan.htmland that the partials it calls (if any) exist at the expected paths.