-
Notifications
You must be signed in to change notification settings - Fork 31
feat: Logical properties #3218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Logical properties #3218
Conversation
|
View your CI Pipeline Execution ↗ for commit f3d0b83 ☁️ Nx Cloud last updated this comment at |
* re-orged Props.mdx files into separate pages * updated MDN links * update properties column with working links and styling * updated statuses for pages that will receive new logical properties * formatted * fix Responsive Properities story * applied Cass's feedback
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3218 +/- ##
==========================================
- Coverage 89.78% 82.03% -7.75%
==========================================
Files 361 75 -286
Lines 5120 1414 -3706
Branches 1611 465 -1146
==========================================
- Hits 4597 1160 -3437
+ Misses 515 251 -264
+ Partials 8 3 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…l vs Physical prop resolution (#3234) * working PoC * fix build and format * lint fixes * some more refactoring * fix existing test failures * add test for getPropertyMode * updated gamutprovider to include useLogicalProperties * fix failiing tests * more test fixes * formatted * add logicalprops switcher to toolbar * updated shorthand in margin related CSS properties * fix linting issue re: physical * update docs to show logical prop updates to margin related props * updated padding too * updated Usage Guide and clean up * add new file to explain logical and physical properties * update docs for readibility * formatted and cleaned up * fix tests and edit MockGamutProvider to use useLogicalProperties * temp fix for test failure * removed useLogicalProperties from contextValue b.c. it's not used anymore * added toolbar button for direction * address Cass's feedback
* working PoC * fix build and format * lint fixes * some more refactoring * fix existing test failures * add test for getPropertyMode * updated gamutprovider to include useLogicalProperties * fix failiing tests * more test fixes * formatted * add logicalprops switcher to toolbar * updated shorthand in margin related CSS properties * fix linting issue re: physical * update docs to show logical prop updates to margin related props * updated padding too * updated Usage Guide and clean up * add new file to explain logical and physical properties * update docs for readibility * formatted and cleaned up * fix tests and edit MockGamutProvider to use useLogicalProperties * temp fix for test failure * start on border related logical props * updated more border props * formatted * added border color props * grammar * formatted
|
📬 Published Alpha Packages: |
|
🚀 Styleguide deploy preview ready! Preview URL: https://698a56017470635adadfcd98--gamut-preview.netlify.app |
Overview
Updates
Gamut:
Storybook:
PR Checklist
Related PRs:
Testing Instructions
Don't make me tap the sign.
PR Links and Envs