[TrayIcon] Bug: Tray will not show up on GUID conflict #829
+89
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagusnl
added
Bug
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Member
Author
|
@sentry review |
EP's OldTaskbar practically replaces the Explorer's taskbar to use the old W10 taskbar, thus restoring old behavior. Signed-off-by: Bagus Nur Listiyono <[email protected]>
neon-nyan
requested changes
Dec 8, 2025
Member
neon-nyan
left a comment
neon-nyan
left a comment
There was a problem hiding this comment.
Other than these reviews, all good.
Fix PR comments by @neon-nyan 1. Use process.WaitForExit() on ForceRestart method 2. Use `using` on RegistryRoot for isOldTaskbar_EP() method Acked-by: Kemal Setya Adhi <[email protected]> Signed-off-by: Bagus Nur Listiyono <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Goal
Tray (Taskbar) icon silently errors and not shown itself when it's Guid somehow conflicts causing the tray to not show up and you cannot raise the window back if its hidden.
This bug seems to happen on newer W11 Insider build where if an app from different path trying to use same Guid, it will not allow it.It was EP's old taskbar behavior, fixed in 399895fPR Status :