N°8698 - Fix webhook with prepare_payload_callback#27
Merged
jf-cbd merged 1 commit intoCombodo:masterfrom Sep 11, 2025
Merged
Conversation
github-project-automation
bot
moved this to First review needed
in Combodo PRs dashboard
github-project-automation
bot
moved this from First review needed
to Finished
in Combodo PRs dashboard
jf-cbd
changed the title
Member
|
Hello @peckpeck, thanks for the fix ! |
Member
|
We send stickers to people from the community that helped us to improve iTop (or its extensions), would you like to get some ? If yes, please text me at community[at]combodo.com and telling me the address you'd like to receive them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base information
Symptom (bug)
Since we upgraded to itop 3.2.2 our webhooks failed to run.
Our webhook use a payload call back we wrote and our webhook service told told us that there was no payload.
Reproduction procedure (bug)
On iTop 3.2.2
Create a webhook and use a callback to create the payload instead of a JSON.
The payload is empty on calls.
Cause (bug)
See 1 line fix
Proposed solution (bug and enhancement)
See 1 line fix
Checklist before requesting a review