N°9340 - fix: Align FiberChannelInterface and LogicalInterface with PhysicalInterface naming#784
Open
Hipska wants to merge 1 commit intoCombodo:developfrom
Open
N°9340 - fix: Align FiberChannelInterface and LogicalInterface with PhysicalInterface naming#784Hipska wants to merge 1 commit intoCombodo:developfrom
Hipska wants to merge 1 commit intoCombodo:developfrom
Conversation
github-project-automation
bot
moved this to First review needed
in Combodo PRs dashboard
Member
|
Accepted in functional review. |
jf-cbd
moved this from First review needed
to Pending technical review
in Combodo PRs dashboard
jf-cbd
changed the title
Contributor
Author
|
Well, the naming will be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base information
Objective
Align the naming of
FiberChannelInterfaceandLogicalInterfaceinterfaces to be consistent withPhysicalInterfacenaming. This will make ordering more logical when listing network interfaces.Proposed solution
Add missing dictionary entries.
No unit test as it are just dictionary items.
Checklist before requesting a review