N°9088 Allow extension uninstallation from production-modules folder#824
Open
Timmy38 wants to merge 2 commits intofeature/uninstallationfrom
Open
N°9088 Allow extension uninstallation from production-modules folder#824Timmy38 wants to merge 2 commits intofeature/uninstallationfrom
Timmy38 wants to merge 2 commits intofeature/uninstallationfrom
Conversation
odain-cbd
reviewed
Feb 27, 2026
| { | ||
| $index = $idx ?? $this->GetStepIndex(); | ||
|
|
||
| $bMandatoryRemoteExtension = !$this->oWizard->GetParameter('force-uninstall', false); |
Contributor
There was a problem hiding this comment.
$bMandatoryRemoteExtension purpose is not so clear. please se if the naming could help
Contributor
Author
There was a problem hiding this comment.
Name changed to $bRemoteExtensionsShouldBeMandatory
odain-cbd
reviewed
Feb 27, 2026
setup/extensionsmap.class.inc.php
Outdated
| } | ||
|
|
||
| public function GetAllExtensionsOptionInfo(): array | ||
| public function GetAllExtensionsOptionInfo(bool $bMandatoryRemoteExtension = true): array |
Contributor
There was a problem hiding this comment.
2 methods got a new parameter. is it covered by new usecases?
odain-cbd
requested changes
Feb 27, 2026
odain-cbd
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.