Set ContentDir when TestConfig is created#63
Set ContentDir when TestConfig is created#63yuumasato wants to merge 1 commit intoComplianceAsCode:mainfrom
Conversation
NewTestConfig() always returns a TestConfig with ConentDir empty. But by the time we create the TestConfig we already know the content directory that should be used, since DefineFlags() runs on TestMain().
|
@yuumasato: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| Platform: platform, | ||
| ContentImage: contentImage, | ||
| ContentDir: "", // Will be set during setup | ||
| ContentDir: contentDir, |
There was a problem hiding this comment.
Aren't I already setting that in https://github.com/ComplianceAsCode/ocp4e2e/pull/61/files#diff-fe44f09c4d5977b5f5eaea29170b6a0748819c9d02271746a20d81a5f3efca17R74?
There was a problem hiding this comment.
You are, so that is likely not the root cause of manual remediations not being run
There was a problem hiding this comment.
So your PR, and this PR, both probably solve content-dir for openshift/release#69497.
But don't explain why the manual remediation is not working.
2 participants
NewTestConfig() always returns a TestConfig with ConentDir empty.
But by the time we create the TestConfig we already know the content directory that should be used, since DefineFlags() runs on TestMain().