expires instead of created. custom expiry times#120
Merged
BigSpaceships merged 6 commits intomainfrom Mar 28, 2026
Merged
Conversation
BigSpaceships
requested changes
Mar 19, 2026
Contributor
BigSpaceships
left a comment
BigSpaceships
left a comment
There was a problem hiding this comment.
What happens when the tokens become null?
(we talked about it on slack but putting it here incase someone else looks at it)
BigSpaceships
approved these changes
Mar 23, 2026
Contributor
BigSpaceships
left a comment
BigSpaceships
left a comment
There was a problem hiding this comment.
Looks good to me, but I fixed some things so someone else should look too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tokens and Sessions now have expiry instead of creation.
Why
Token expiration should be customizable for admins
Test Plan
local testing
Env Vars
no
Checklist