Fix Docker build script path handling for subdirectory node sources in mkconcore#428
Merged
pradeeban merged 6 commits intoControlCore-Project:devfrom Feb 20, 2026
Conversation
Member
|
@Titas-Ghosh there are many irrelevant linechanges included in this PR in the mkconcore.py file. Perhaps an EoL character? Can you make sure your PR changes the minimal number of files and the least amount of lines necessary in the files? That will help with the PR review and maintenance of the code in the long term. |
a5c35b0 to
7a1f0e2
Compare
Author
|
Hi @pradeeban, thanks for pointing this out, actually you have mentioned this in one of my previous PRs also , i should have been more careful , while making this PR , keeping the maintenance factor in mind . I will make sure this doesn't happen in my future PRs from now on. I’ve cleaned the branch to keep the PR scoped to only the necessary changes only in these two files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #420
Hi @pradeeban ,
This PR fixes Docker script generation in
mkconcorefor node sources in subdirectories (for example script.py).Problem
Generated
buildscripts used incorrect relative paths (../src/...) and incorrect directory return (cd ..) when Docker build directories were nested (likedocker-subdir/script).This broke Docker workflows for valid subdirectory source layouts.
Fix
mkconcore.py, compute Docker build directory depth and derive a correct relative prefix.cpcommands tosrc/....cd <prefix>to return to the study root after each node build step.Test
Added regression test in test_cli.py:
test_run_command_docker_subdir_source_build_pathsout/buildcontains correct../../src/...copy paths andcd ../../for subdirectory sources.