fix: add include guard, default_maxtime, tryparam, and initval bounds…#438
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Feb 20, 2026
Merged
Conversation
… check to concore.hpp
Author
|
Hey @pradeeban just a quick check, this fixes the #422 parity/safety issues, but I still don’t see C++ enforcing termination unless nodes explicitly use while (concore.simtime < concore.maxtime). If that’s intentional, all good. If not, I can send a tiny follow-up PR for that only. |
Member
|
@avinxshKD you can send a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #422
concoredocker.hpp had default_maxtime, load_params, tryparam, a #ifndef guard, and a bounds check in initval, concore.hpp had none of them. Ported them over and added the if (val.empty()) return val; guard so initval doesn't segfault on empty input.
Changes:
#ifndef CONCORE_HPP guard added
maxtime field + default_maxtime() reads ./in/1/concore.maxtime
params field + load_params() + tryparam() so params aren't silently dropped
initval() no longer crashes on empty input