update mkconcore logic to select scripts to add to src#439
Conversation
|
@pradeeban , I have recreated the PR, those unnecessary line changes were shown due to some issue related to CRLF. |
|
@pradeeban If we follow a julia first approach, we should technically replace mkconcore.py (our orchestrator) with mkconcore.jl? But since it is just an orchestrator code, changing it to jl might not be of much benefit. Why I felt this question was important to ask :
|
|
ok, good points! I think it is unnecessary to have a strong time investments unless there is a performance impact. Do you see a performance benefit in doing so? In that case, state that in your proposal. If not, also state that in your proposal and justify the decision either way. One thing we know for sure is Python is not the ideal language for latency-sensitve use cases of concore. |
|
since mkconcore.py is just going to be called at the initial state, it won't actually matter much even if there is some improvements done by mkconcore.jl (julia version will still be very minutely faster in this case). regardless, I believe I should develop mkoncore.jl (even if it is time consuming), though the benefits are less immediately, if the project vision for right now is julia implementation and the long term vision of control-core-project is low latency and first-class performance julia should be used here too. We could always revert back to python orchestrator in case of too complications :) Thanks for your guidance! |
|
Awesome plan. It could also make a little research paper, which you should add as an optional (i.e., "if time permits") outcome as part of your GSoC proposal. |
|
Thanks for your guidance Pradeeban Sir! |
This fixes #429
changes made: