fix: use concore.maxtime in C++ test loops#441
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Feb 21, 2026
Merged
fix: use concore.maxtime in C++ test loops#441pradeeban merged 1 commit intoControlCore-Project:devfrom
pradeeban merged 1 commit intoControlCore-Project:devfrom
Conversation
Author
|
Hey @pradeeban kept scope limited to loop termination only. Happy to adjust if you want anything changed... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #422 (after #438): changed the C++ test loops to use concore.maxtime instead of hardcoded Nsim (left Nsim in cpymat.cpp only for avg output)
This keeps C++ runtime termination in line with the other bindings and with configured maxtime,