Add Alarms Sound#10
Open
eldelahoz wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for customizable alarm sounds and notifications when a timer expires in the PowerToys Run Timer plugin. It introduces new user-configurable options for enabling/disabling alarm sounds, setting a custom alarm sound file, and specifying the alarm duration. The implementation includes new services for sound playback and toast notifications, as well as updates to the plugin's settings and project configuration.
Key changes include:
Alarm Sound and Notification Feature:
SoundServiceclass to handle playing alarm sounds, supporting both default and user-specified.wavfiles, and allowing the alarm to play for a configurable duration.ToastNotificationServiceclass to display toast notifications with a "Stop Alarm" action when a timer expires, integrating with the alarm sound logic.TimerResultServiceto use the new sound and notification services, playing the alarm sound and showing a toast notification when timers complete, based on user settings.Settings and User Options:
Settingsclass and the plugin'sAdditionalOptionsto include options for enabling alarm sounds, specifying a custom sound path, and setting the alarm duration (1–30 seconds). These settings are now respected when timers expire.Project and Resource Configuration:
net8.0-windows10.0.17763.0, enable Windows targeting, and ensure all.wavfiles in theSoundsdirectory are copied to the output, supporting custom and default alarm sounds.