Open
Conversation
Contributor
|
looks good, but please resolve the conflict first |
|
We should review it and maybe redo some of the parts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions
New Feature Submissions
Closes [Refactor] Restructure our files #1590
Notes
Please note, your code must pass all tests and lint checks before it can be merged.
PR Description
Restructured components to ideally be more developer-friendly. Removed components/smart directory
Moved some of the loose files that were filled with pure functions in the root to utils and fixed pathing issues in relevant files.
Testing
Has the code been tested, or does it need double checking?
I've run through the site and didn't see anything broken by my changes, but a lot was moved around were made. Build would've failed if a path was wrong, I'd think.