fix sender waits until receiver attaches#17
Open
frogarian wants to merge 1 commit into
Open
Conversation
Upstream-Status: Pending
Owner
|
I'll have to think about this a little. There are also some asserts in channel to prevent issues like this (which don't apply here obviously), but I'm not a fan of exceptions. I think a more sane approach could be to handle this with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no receiver attaches to the channel, the sender might wait infinitely.
My approach here is up to debate. Adding a timeout parameter to
channel_state::emitwould be a more flexible option.One drawback I ran into using my approach was that the sender could have already put a message into the queue (in
sender<T>::send), but then fails to emit due to a missing receiver. To cope with that I introduced the draining of the queue in (comparechannel.inl).