Feat/unique items validation fixed #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add uniqueItems validation using fast-deep-equal for deep comparison - Fix array validation by adding array-level getZodChain that preserves isRequired - Prevent object property processing from double-chaining arrays - Add comprehensive tests for uniqueItems validation scenarios - Add fast-deep-equal dependency for reliable deep equality checks The uniqueItems validation is applied last in the validation chain since .refine() returns ZodEffects which doesn't support further method chaining. Arrays now properly handle both required and optional status while supporting uniqueItems validation without duplication.
itaysabato
commented
Jul 24, 2025
itaysabato
commented
Jul 24, 2025
itaysabato
commented
Jul 24, 2025
itaysabato
commented
Jul 24, 2025
itaysabato
commented
Jul 24, 2025
itaysabato
commented
Jul 24, 2025
- Return false immediately when duplicate found instead of processing entire array - Functionally equivalent but more efficient for arrays with duplicates - Updated test snapshots to reflect optimized logic
itaysabato
commented
Jul 24, 2025
itaysabato
commented
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.