Formating Aliases in the instrument page

[PouyaMohseni]

• display aliases using nested rows
• show verification status and action options for aliases
• remove source information as part of improvements related to feat: support multiple sources for a single instrument name #443

resolves #423, resolves #420

Logged in:

Logged out:

[yinanazhou]

A few tips for making PRs easier to review:

• Concise commit title that summarizes the changes
• Descriptive commit body about what is done
• Reference the issue in the footer in the commit message
• Screenshots that show the before&after if necessary

[yinanazhou]

Instead of listing the alias in separate entire row as implemented, nested rows inside the alias cell would make more sense.

[PouyaMohseni]

Instead of listing the alias in separate entire row as implemented, nested rows inside the alias cell would make more sense.

Like this? I believe it makes scrolling harder and also creates a lot of blank space, which makes the last three columns, which are relevant for any alias, feel unused. I tried removing stripes and removing some of the borders of the rows to make it clearer that aliases share the first three columns with the main label, but I couldn't get it to look straightforward.

[yinanazhou]

You can try to use three columns for alias instead of three rows. You may also need to consider the ordering of the columns because now the last source column looks confusing

[PouyaMohseni]

The source is not the last column; There are verification and action columns for a logged-in user, three of these are shared with aliases:

[yinanazhou]

I meant the last column in the screenshot

[PouyaMohseni]

Yes, but should I consider reordering all of these 3 columns? Thank you,

[PouyaMohseni]

It is also expected to have a contributor column (#344), which is also relevant to aliases.

[yinanazhou]

Please convert this to draft if not ready for review.

[PouyaMohseni]

While we are discussing having a separate page for each instrument name, I propose the following structure for the Instrument Detail and Instrument Name Detail pages:

---

Instrument Detail Page

• Information about the instrument
• A table of instrument names with the following columns:
  • Language
  • Name
  • Alias (displayed as a nested under each entry)
  • Action (contains a More button)
  • Verification status, shown next to each label (name or alias)

---

Instrument Name Detail Page

• Information about the instrument
• Information about the selected name entry
• An action button to Delete the instrument name
• A table of visible sources, including:
  • Source
  • Reviewe
  • Action (e.g., Delete to remove the instrument-name–source relation)

[yinanazhou]

Please use rebase instead of merge if possible

[yinanazhou]

Are the screenshots in the description the final version? The layout looks much better. Can you merge the Name and Verification Status column tho? You can put the info icon in the Name column. I will check the code after this is done.

[PouyaMohseni]

Yes, the screen shots are for the current stage.

I've tried merging two columns. The main problem is that displaying left-to-right languages would cause the Name and Verification Status directions to differ, which wouldn't look good. Maybe changing the status options to small images, like a check mark or an X, could solve this, but I'm not sure if that's what we want.

[yinanazhou]

Can you show me what you are saying?