Stonesense Info Panel mockup (dont merge)#226
Open
realSquidCoder wants to merge 35 commits intoDFHack:masterfrom
Open
Stonesense Info Panel mockup (dont merge)#226realSquidCoder wants to merge 35 commits intoDFHack:masterfrom
realSquidCoder wants to merge 35 commits intoDFHack:masterfrom
Conversation
Collaborator
Author
|
Maybe should figure out how to use al_do_multiline_text() |
realSquidCoder
changed the title
ab9rf
requested changes
Mar 26, 2025
ab9rf
requested changes
Mar 26, 2025
| } | ||
|
|
||
| allCurrentChars += nextChar; // Append the character if it fits | ||
| std::string fitTextToWidth(const std::string input, int width) { |
Member
There was a problem hiding this comment.
consider using std::string_view input here, not a big change but might eliminate a copy-construct
ab9rf
requested changes
Mar 26, 2025
Collaborator
Author
|
can i get another look thru to see what i missed or forgot? |
ab9rf
reviewed
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just meant to show off what I'm working on in a way that people can more easily discover.