feat: add delete bucket method in client#32
Open
natthan-pigoux wants to merge 2 commits into
Open
Conversation
natthan-pigoux
force-pushed
the
feat_delete_bucket
branch
2 times, most recently
from
0ec2ff0 to
c64cbb6
Compare
natthan-pigoux
force-pushed
the
feat_delete_bucket
branch
from
c64cbb6 to
b2846db
Compare
Author
|
Shall I also update the benchmark tests which are using the boto client |
Author
|
Concerning the unit tests, is that expected that the seaweedfs tests fail? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dropping boto dependency (c.f. DIRACGrid/diracx#901) in diracx I remarked that
delete_bucketmethod was not implemented but used in diracx tests.Related to DIRACGrid/diracx#712
_baseClientadd a_prepareand_parsemethods fordelete_bucketdelete_bucketmethodNote: some parts are based on IA generated code.