Dataset-saving infrastructure phase 1#688
Merged
Cadair merged 68 commits intoDKISTDC:mainfrom Mar 31, 2026
Merged
Conversation
Merging this PR will not alter performance
Performance Changes
Comparing Footnotes |
Contributor
Author
|
I'm sure there are other issues remaining but the bulk of the current error are due to slicing bugs in |
397b1de to
7aca21a
Compare
Contributor
Author
Contributor
Author
|
pre-commit.ci autofix |
Cadair
requested changes
Mar 9, 2026
Member
Cadair
left a comment
There was a problem hiding this comment.
(Blocking because of git dependency)
Cadair
reviewed
Mar 17, 2026
Cadair
reviewed
Mar 17, 2026
We can remove this if and when we figure out why it's happening
Cadair
reviewed
Mar 24, 2026
Co-authored-by: Stuart Mumford <stuart@cadair.com>
Cadair
reviewed
Mar 30, 2026
Co-authored-by: Stuart Mumford <stuart@cadair.com>
Co-authored-by: Stuart Mumford <stuart@cadair.com>
Co-authored-by: Stuart Mumford <stuart@cadair.com>
Cadair
reviewed
Mar 30, 2026
Cadair
reviewed
Mar 30, 2026
Cadair
approved these changes
Mar 30, 2026
Member
Cadair
left a comment
There was a problem hiding this comment.
Think it still needs the 2nd changelog entry but not that important.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #671