-
Notifications
You must be signed in to change notification settings - Fork 118
[DRAFT] Add question and answer flag to V2 API #3590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
momo3404
wants to merge
7
commits into
api_v2_dmponline
Choose a base branch
from
momo/api-v2-qa-flag
base: api_v2_dmponline
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b3d9c2d
Update `plans_controller` to include question and answer flag
momo3404 62c4498
Add `fetch_all_q_and_a` function to `research_output_presenter`
momo3404 8f3beaf
Update `_show,json.jbuilder` to include questions and answers
momo3404 ccc7699
Reorganize files and functions
momo3404 865d5de
Remove plan parameter from fetch function
momo3404 1de5bfd
Remove output from extension json
momo3404 12e0a03
Change flag name to `complete` and JSON to `complete_plan`
momo3404 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,6 +35,22 @@ def identifier | |
| Identifier.new(value: Rails.application.routes.url_helpers.api_v2_plan_url(@plan)) | ||
| end | ||
|
|
||
| # Fetch all questions and answers from a plan, regardless of theme | ||
| def fetch_all_q_and_a # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity | ||
| return [] unless @plan&.questions.present? | ||
|
|
||
| @plan.questions.filter_map do |q| | ||
| a = @plan.answers.find { |ans| ans.question_id == q.id } | ||
| next unless a.present? && !a.blank? | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think |
||
|
|
||
| { | ||
| title: "Question #{q.number || q.id}", | ||
| question: q.text.to_s, | ||
| answer: a.text.to_s | ||
| } | ||
| end | ||
| end | ||
|
|
||
| private | ||
|
|
||
| # Retrieve the answers that have the Budget theme | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just remove the safe navigation operator from @plan.