Skip to content

Conversation

@FrancescoMolinaro
Copy link
Contributor

@FrancescoMolinaro FrancescoMolinaro commented Dec 1, 2025

References

Backporting of #4764 to dspace-7_x

Description

Implemented route guard to prevent logged user from accessing register page.
The user will be redirected on page 404 if already logged in.

Instructions for Reviewers

To test this feature you can try and log in while navigating the register page.
The logged user will be redirected to the "Not found" page.

List of changes in this PR:

Implemented new route guard to check if the user is authenticated.
Adapted route config.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@FrancescoMolinaro FrancescoMolinaro changed the base branch from main to dspace-7_x December 1, 2025 15:38
@tdonohue tdonohue changed the title [Dspace-7_x] backporting of https://github.com/DSpace/dspace-angular/pull/4764#4900 [Port dspace-7_x] Add route guard to prevent access to register page for authenticated users Dec 1, 2025
@tdonohue tdonohue added bug authorization related to authorization, permissions or groups 1 APPROVAL pull request only requires a single approval to merge labels Dec 1, 2025
@tdonohue tdonohue self-requested a review December 1, 2025 16:07
@tdonohue tdonohue added this to the 7.6.6 milestone Dec 3, 2025
@tdonohue
Copy link
Member

tdonohue commented Dec 3, 2025

Closing and reopening to trigger tests to re-run. Somehow they got "stuck" in this PR and never ran.

@tdonohue tdonohue closed this Dec 3, 2025
@tdonohue tdonohue reopened this Dec 3, 2025
@tdonohue tdonohue moved this from ✅ Done to 👍 Reviewer Approved in DSpace Maintenance (9.x, 8.x, 7.6.x) Dec 3, 2025
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @FrancescoMolinaro ! This backport looks good. Code looks the same and I manually tested it on a 7.x instance and it's working well. I'm waiting on the automated tests to finish re-running (they didn't trigger previously) and then I'll merge it.

@tdonohue tdonohue merged commit 28c745e into DSpace:dspace-7_x Dec 3, 2025
13 of 14 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace Maintenance (9.x, 8.x, 7.6.x) Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge authorization related to authorization, permissions or groups bug

Projects

Development

Successfully merging this pull request may close these issues.

2 participants