Skip to content

Kinfolk gifts & tribe selection#1075

Closed
Biplume wants to merge 10 commits into
DarkPack13:masterfrom
Biplume:kinnies
Closed

Kinfolk gifts & tribe selection#1075
Biplume wants to merge 10 commits into
DarkPack13:masterfrom
Biplume:kinnies

Conversation

@Biplume
Copy link
Copy Markdown
Contributor

@Biplume Biplume commented May 20, 2026

About The Pull Request

see changelog for most things
removed renown from kinfolk because kinfolk rarely have renown and it works differently for them anyway
kinfolk get only singular rank 1 gifts with willpower costs/no costs

Why It's Good For The Game

Changelog

🆑
add: Tribe selection for Kinfolk
add: Chain talk for Bone Gnawer Kinfolk, Balance for Stargazers, and Whisper Catching for Shadow Lords.
fix: Scent of the True Form now properly registers mundane versus not.
/:cl:

@Biplume Biplume requested a review from a team as a code owner May 20, 2026 05:01
@Biplume Biplume marked this pull request as draft May 20, 2026 05:01
@Biplume Biplume changed the title gift spam & kinfolk gifts??? More gifts to Garou subsplats, Kinfolk gifts & tribe selection May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

You currently have a negative Fix/Feature pull request delta of -59. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@Biplume Biplume changed the title More gifts to Garou subsplats, Kinfolk gifts & tribe selection Kinfolk gifts & tribe selection May 20, 2026
@Biplume Biplume marked this pull request as ready for review May 20, 2026 10:27
@Biplume
Copy link
Copy Markdown
Contributor Author

Biplume commented May 20, 2026

need to look into this more for how they should be assigned

@FalloutFalcon FalloutFalcon marked this pull request as draft May 20, 2026 15:39
@Biplume
Copy link
Copy Markdown
Contributor Author

Biplume commented May 22, 2026

considered making it a toggle on whether or not you get gifts at all but given garou dont even have full disc selection ive settled on "just dont use them if you dont want them"

@Biplume Biplume marked this pull request as ready for review May 22, 2026 08:06
@Biplume Biplume marked this pull request as draft May 22, 2026 08:59
@Biplume
Copy link
Copy Markdown
Contributor Author

Biplume commented May 23, 2026

ok ready for review for real, given no disc selection i cant do much more here

@Biplume Biplume marked this pull request as ready for review May 23, 2026 05:07
/datum/subsplat/werewolf/tribe/garou
abstract_type = /datum/subsplat/werewolf/tribe/garou
fera_restriction = SPLAT_GAROU
fera_restriction = SPLAT_GAROU || SPLAT_KINFOLK
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OR operator wont really work here. This just evaluates to spalt_garou. It prob needs to be made a list.

Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does fera_restriction just not prevent them then? it was working in my testing

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a var i made for future proofing. So it doesn't do anything atm

Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
@FalloutFalcon
Copy link
Copy Markdown
Member

pr maker gone (for now atleast)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants