-
Notifications
You must be signed in to change notification settings - Fork 1.7k
MPD Update on Validity Expiration #4864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cotid-qualabs
wants to merge
17
commits into
Dash-Industry-Forum:development
Choose a base branch
from
qualabs:feature/mpd-update-on-validity-expiration
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MPD Update on Validity Expiration #4864
cotid-qualabs
wants to merge
17
commits into
Dash-Industry-Forum:development
from
qualabs:feature/mpd-update-on-validity-expiration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ValidiyExpiration] Update the manifest when the InbandEventStream value attribute is three
…/sample-page [ValidityExpiration] Sample page
…/mpd-update-on-validity-expiration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements and demonstrates the handling of MPD update events (specifically
value3) as defined by the DASH standard, allowing for in-band signaling to update the manifest. It introduces new events, enhances manifest loading and event processing, and adds a new sample and comprehensive unit tests for the feature.Highlights
schemeIdUriurn:mpeg:dash:event:2012andvalue3, which indicates a manifest update.MPD_EXPIRE_UPDATEevent has been added to the core events. TheManifestLoadernow listens for this event and re-parses the manifest XML provided within the event, effectively updating the current manifest. TheMediaPlayernow passes themanifestModelto theManifestLoaderto facilitate this process.EventControllerhas been updated to differentiate between variousMPD_VALIDITY_EXPIRATIONevent values: 1 for reload, 2 for patch, and 3 for update. Forvalue3 events, it extracts the new manifest XML from the event's message data and triggers theMPD_EXPIRE_UPDATEevent. A placeholder_patchManifestfunction is included forvalue2 events, noting that patching is not yet supported. TheMANIFEST_VALIDITY_CHANGEDevent now includes aninbandEventflag.ManifestUpdaternow incorporates logic to disable automatic manifest refreshing if an in-band event (specifically one with aminimumUpdatePeriodof 0) triggers a manifest validity change, preventing redundant or conflicting manifest updates.DashAdapternow parsesmessageDatafor non-ID3 events into a UTF-8 string, making the content accessible for manifest updates. New constants forMPD_VALIDITY_EXPIRATIONvalues (RELOAD, PATCH, UPDATE) have been added. A new HTML sample (samples/mpd-event/mpd-update-event.html) has been added to demonstrate this feature, along with corresponding updates tosamples/samples.json.ManifestLoaderandEventControllerto ensure proper functioning of the new manifest update logic and event handling.DashAdaptertests were also updated to cover the parsing ofparsedMessageDatafor non-ID3 events.