filter capabilities on number of audio channels #4886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annels., specify whether lfe should be considered in channel count. # Conflicts: # src/streaming/utils/AudioChannelConfiguration.js
stschr
reviewed
Nov 12, 2025
| let channels = null; | ||
|
|
||
| if (!audioChannelConfigs && prsl) { | ||
| audioChannelConfigs = prsl[DashConstants.AUDIO_CHANNEL_CONFIGURATION]; |
Contributor
There was a problem hiding this comment.
IMHO this might fail if neither representation nor prsl contain an AudioChannelConfig.
stschr
reviewed
Nov 12, 2025
| }, | ||
| { | ||
| id: '11', | ||
| preselectionComponents: '1 2', |
Contributor
There was a problem hiding this comment.
Can we convert this to a Preselection with only one component?
Background: Up to now, we do not support "MRMP" (=multi-representation) and this preselection gets removed regardless of all other properties (see: _removeMultiRepresentationPreselections() gets called by filterUnsupportedFeatures() )
stschr
reviewed
Nov 12, 2025
Contributor
stschr
left a comment
stschr
left a comment
There was a problem hiding this comment.
I left a few comment in code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the streaming.capabilities.filterAudioChannelConfiguration settings parameter to specify that the channels property should be populated during the MediaCapabilities queries.
{ "type": "media-source", "audio": { "contentType": "audio/mp4; codecs=\"mp4a.40.42\"", "sampleRate": 48000, "channels": 2 } }With this change it's possible to query whether a multichannel or stereo decoder is available.