-
Notifications
You must be signed in to change notification settings - Fork 469
chore(vendor/psutil): upgrade psutil #15414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 251 ± 4 ms. The average import time from base is: 255 ± 4 ms. The import time difference between this PR and base is: -3.2 ± 0.2 ms. Import time breakdownThe following import paths have appeared:
|
Performance SLOsComparing candidate avara1986/APPSEC-60046_upgrade_psutil (7e9bf59) with baseline main (6a92ecd) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.221µs (SLO: <10.000µs 📉 -47.8%) vs baseline: 📈 +20.7% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.1% ✅ ospathbasename_noaspectTime: ✅ 1.082µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.4% Memory: ✅ 40.423MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.160µs (SLO: <10.000µs 📉 -38.4%) vs baseline: +0.6% Memory: ✅ 40.403MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +5.2% ✅ ospathjoin_noaspectTime: ✅ 2.299µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +0.7% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 3.546µs (SLO: <10.000µs 📉 -64.5%) vs baseline: +1.4% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ ospathnormcase_noaspectTime: ✅ 0.567µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -2.2% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.805µs (SLO: <10.000µs 📉 -52.0%) vs baseline: -1.9% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.594µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.3% Memory: ✅ 40.442MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.3% ✅ ospathsplitdrive_aspectTime: ✅ 3.686µs (SLO: <10.000µs 📉 -63.1%) vs baseline: -0.8% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.697µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -1.4% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.603µs (SLO: <10.000µs 📉 -54.0%) vs baseline: +0.7% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 1.380µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +0.2% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.7% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.445µs (SLO: <20.000µs 📉 -82.8%) vs baseline: 📈 +18.5% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 204.147µs (SLO: <220.000µs -7.2%) vs baseline: +2.4% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.296µs (SLO: <20.000µs 📉 -83.5%) vs baseline: +1.4% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.868µs (SLO: <230.000µs -6.1%) vs baseline: +1.0% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.189µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.7% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.698µs (SLO: <150.000µs -9.5%) vs baseline: -1.2% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.2% ✅ 1-rate-metric-1-timesTime: ✅ 3.110µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +1.4% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 215.624µs (SLO: <250.000µs 📉 -13.8%) vs baseline: +1.3% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.278ms (SLO: <22.000ms -7.8%) vs baseline: +0.5% Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +5.6% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.238ms (SLO: <2.300ms -2.7%) vs baseline: -1.5% Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.405ms (SLO: <1.550ms -9.3%) vs baseline: +0.6% Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +5.4% ✅ 100-rate-metrics-100-timesTime: ✅ 2.211ms (SLO: <2.550ms 📉 -13.3%) vs baseline: +0.7% Memory: ✅ 35.173MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +5.4% ✅ flush-1-metricTime: ✅ 4.404µs (SLO: <20.000µs 📉 -78.0%) vs baseline: -0.5% Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 173.605µs (SLO: <250.000µs 📉 -30.6%) vs baseline: +0.4% Memory: ✅ 35.311MB (SLO: <35.500MB 🟡 -0.5%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.182ms (SLO: <2.500ms 📉 -12.7%) vs baseline: -0.4% Memory: ✅ 36.078MB (SLO: <36.500MB 🟡 -1.2%) vs baseline: +5.0% 🟡 Near SLO Breach (20 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
avara1986
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not merge, waiting for @brettlangdon comments :)
Upgrade vendored psutil from 5.6.7 to 7.1.3 to address security vulnerabilities and modernize the dependency.
Key changes:
xml.etree.ElementTreefunctions used to parse input from *BSD kernel (kern.sched.topology_spec)arch/directoriesSecurity improvements: