-
Notifications
You must be signed in to change notification settings - Fork 468
chore: migrate os env call to new package 1/3 #15428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ben.db/APMAPI-1613-linter-rule
Are you sure you want to change the base?
chore: migrate os env call to new package 1/3 #15428
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 248 ± 5 ms. The average import time from base is: 252 ± 6 ms. The import time difference between this PR and base is: -3.9 ± 0.2 ms. Import time breakdownThe following import paths have appeared:
|
chore: change import style for ddtrace.settings._env
4853755 to
dce3336
Compare
Performance SLOsComparing candidate ben.db/APMAPI-1612-migrate-environ-calls (dce3336) with baseline ben.db/APMAPI-1613-linter-rule (91d379a) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.464ms (SLO: <22.300ms -8.2%) vs baseline: ~same Memory: ✅ 66.198MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.1% ✅ exception-replay-enabledTime: ✅ 1.350ms (SLO: <1.450ms -6.9%) vs baseline: +0.8% Memory: ✅ 64.133MB (SLO: <67.000MB -4.3%) vs baseline: +4.8% ✅ iastTime: ✅ 20.469ms (SLO: <22.250ms -8.0%) vs baseline: ~same Memory: ✅ 66.153MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ profilerTime: ✅ 15.566ms (SLO: <16.550ms -5.9%) vs baseline: +0.4% Memory: ✅ 53.915MB (SLO: <54.500MB 🟡 -1.1%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 20.514ms (SLO: <21.750ms -5.7%) vs baseline: -0.3% Memory: ✅ 66.139MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 25.376ms (SLO: <28.200ms 📉 -10.0%) vs baseline: +0.2% Memory: ✅ 67.099MB (SLO: <69.500MB -3.5%) vs baseline: +2.9% ✅ tracerTime: ✅ 20.476ms (SLO: <21.750ms -5.9%) vs baseline: ~same Memory: ✅ 66.198MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.2% ✅ tracer-and-profilerTime: ✅ 22.705ms (SLO: <23.500ms -3.4%) vs baseline: +0.3% Memory: ✅ 67.692MB (SLO: <68.000MB 🟡 -0.5%) vs baseline: +4.8% ✅ tracer-dont-create-db-spansTime: ✅ 19.299ms (SLO: <21.500ms 📉 -10.2%) vs baseline: -0.5% Memory: ✅ 66.035MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.675ms (SLO: <17.500ms -4.7%) vs baseline: +0.2% Memory: ✅ 65.805MB (SLO: <67.000MB 🟡 -1.8%) vs baseline: +4.5% ✅ tracer-nativeTime: ✅ 20.497ms (SLO: <21.750ms -5.8%) vs baseline: ~same Memory: ✅ 67.613MB (SLO: <72.500MB -6.7%) vs baseline: +4.2% ✅ tracer-no-cachesTime: ✅ 18.466ms (SLO: <19.650ms -6.0%) vs baseline: -0.3% Memory: ✅ 65.746MB (SLO: <67.000MB 🟡 -1.9%) vs baseline: +4.5% ✅ tracer-no-databasesTime: ✅ 18.859ms (SLO: <20.100ms -6.2%) vs baseline: +0.2% Memory: ✅ 65.746MB (SLO: <67.000MB 🟡 -1.9%) vs baseline: +4.4% ✅ tracer-no-middlewareTime: ✅ 20.196ms (SLO: <21.500ms -6.1%) vs baseline: +0.2% Memory: ✅ 66.001MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 20.295ms (SLO: <22.000ms -7.8%) vs baseline: +0.4% Memory: ✅ 66.060MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.170ms (SLO: <19.850ms -8.5%) vs baseline: +0.7% Memory: ✅ 65.746MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +4.5% ✅ errortracking-enabled-userTime: ✅ 18.118ms (SLO: <19.400ms -6.6%) vs baseline: +0.4% Memory: ✅ 65.824MB (SLO: <66.500MB 🟡 -1.0%) vs baseline: +4.6% ✅ tracer-enabledTime: ✅ 18.132ms (SLO: <19.450ms -6.8%) vs baseline: +0.4% Memory: ✅ 65.785MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +4.5% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.062ms (SLO: <2.300ms 📉 -10.3%) vs baseline: -0.3% Memory: ✅ 52.553MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 2.076ms (SLO: <2.250ms -7.7%) vs baseline: ~same Memory: ✅ 52.612MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.066ms (SLO: <2.300ms 📉 -10.2%) vs baseline: -0.2% Memory: ✅ 52.612MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.589ms (SLO: <4.750ms -3.4%) vs baseline: -0.3% Memory: ✅ 62.089MB (SLO: <65.000MB -4.5%) vs baseline: +4.4% ✅ appsec-postTime: ✅ 6.623ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: -0.7% Memory: ✅ 62.108MB (SLO: <65.000MB -4.4%) vs baseline: +4.5% ✅ appsec-telemetryTime: ✅ 4.620ms (SLO: <4.750ms -2.7%) vs baseline: +0.6% Memory: ✅ 62.108MB (SLO: <65.000MB -4.4%) vs baseline: +4.4% ✅ debuggerTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 45.200MB (SLO: <47.000MB -3.8%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.865ms (SLO: <2.000ms -6.8%) vs baseline: ~same Memory: ✅ 42.015MB (SLO: <49.000MB 📉 -14.3%) vs baseline: +4.5% ✅ profilerTime: ✅ 1.917ms (SLO: <2.100ms -8.7%) vs baseline: -0.1% Memory: ✅ 46.497MB (SLO: <47.000MB 🟡 -1.1%) vs baseline: +4.4% ✅ resource-renamingTime: ✅ 3.368ms (SLO: <3.650ms -7.7%) vs baseline: -0.3% Memory: ✅ 52.711MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.1% ✅ tracerTime: ✅ 3.374ms (SLO: <3.650ms -7.6%) vs baseline: +0.3% Memory: ✅ 52.730MB (SLO: <53.500MB 🟡 -1.4%) vs baseline: +5.2% ✅ tracer-nativeTime: ✅ 3.360ms (SLO: <3.650ms -7.9%) vs baseline: -0.1% Memory: ✅ 54.179MB (SLO: <60.000MB -9.7%) vs baseline: +4.6% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 309.361ms (SLO: <320.950ms -3.6%) vs baseline: +0.2% Memory: ✅ 32.637MB (SLO: <34.500MB -5.4%) vs baseline: +4.9% ✅ deep-profiledTime: ✅ 327.764ms (SLO: <359.150ms -8.7%) vs baseline: +0.1% Memory: ✅ 38.306MB (SLO: <39.000MB 🟡 -1.8%) vs baseline: +3.8% ✅ mediumTime: ✅ 7.003ms (SLO: <7.400ms -5.4%) vs baseline: ~same Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +3.6% ✅ shallowTime: ✅ 0.946ms (SLO: <1.050ms -9.9%) vs baseline: +0.7% Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +3.4%
|
Description
This PR migrates some of the os.environ (and equivalent) calls to the new
settings._envpackage.Additional Notes
Merging into: #15299